Fixing files with few typing (mypy) errors #4263

henrikmidtiby · 2025-06-01T20:02:29Z

Overview: What does this pull request change?

In this pull request I have addressed some of the files with only a few reported mypy errors.

Further Information and Comments

To identify files with few mypy errors, I cleared the mypy.ini file so no detected errors would be ignored and then used the follwing command

uv run pre-commit run mypy --all-files | grep "error" | sed 's/:.*//' | uniq -c | sort -n -r

I hope that this approach will make it easier to deal with the large files that needs a lot of type annotations added.

Reviewer Checklist

The PR title is descriptive enough for the changelog, and the PR is labeled correctly
If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
If applicable: newly added functions and classes are tested

…m_scene in the class FadeOut

manim/mobject/three_d/three_d_utils.py

for more information, see https://pre-commit.ci

manim/mobject/three_d/three_d_utils.py

chopan050

Thanks for your contribution! I left some change requests:

manim/animation/animation.py

manim/animation/changing.py

chopan050 · 2025-06-21T23:19:40Z

manim/_config/cli_colors.py

        )

-    return Context.settings(
+    return_val: dict[str, Any] = Context.settings(


This is more a comment than a suggestion, but it's weird that MyPy doesn't detect that Context.settings() already returns a dict[str, Any]...

manim/animation/changing.py

manim/mobject/graphing/scale.py

manim/mobject/logo.py

manim/scene/moving_camera_scene.py

manim/animation/changing.py

Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Cleaner way to indicate the float type Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Co-authored-by: Francisco Manríquez Novoa <[email protected]>

henrikmidtiby · 2025-06-22T20:57:50Z

Thanks for your detailed comments. I have addressed all of the raised issues, in most cases by accepting your suggestions.

chopan050

Thanks!

I missed some last small things in mypy.ini. Could you please check them as well? After that, we should be ready to approve and merge this!

I also noticed that you modified a lot of files, but only some of them are indicated in mypy.ini for MyPy to stop ignoring their errors. Maybe you would like to add some more files in there? In particular, manim.animation.numbers, manim.scene.moving_camera_scene and manim.scene.section seem fine to me and MyPy didn't return any errors after adding them to mypy.ini, although manim.mobject.logo and the other animations you didn't add did throw some errors.

chopan050 · 2025-06-22T21:57:05Z

mypy.ini

@@ -52,12 +52,24 @@ warn_return_any = True
 ignore_errors = True
 disable_error_code = return-value

+[mypy-manim._config.cli_colors.*]


Since cli_colors is a file and not a directory, it's not necessary to end the tag with a .*.

Suggested change

[mypy-manim._config.cli_colors.*]

[mypy-manim._config.cli_colors]

chopan050 · 2025-06-22T21:57:19Z

mypy.ini

+[mypy-manim.animation.changing.*]
+ignore_errors = False
+
+[mypy-manim.animation.fading.*]
+ignore_errors = False
+
+[mypy-manim.animation.updaters.update.*]
+ignore_errors = False


Suggested change

[mypy-manim.animation.changing.*]

ignore_errors = False

[mypy-manim.animation.fading.*]

ignore_errors = False

[mypy-manim.animation.updaters.update.*]

ignore_errors = False

[mypy-manim.animation.changing]

ignore_errors = False

[mypy-manim.animation.fading]

ignore_errors = False

[mypy-manim.animation.updaters.update]

ignore_errors = False

chopan050 · 2025-06-22T21:57:28Z

mypy.ini

@@ -73,12 +85,21 @@ ignore_errors = True
 [mypy-manim.mobject.*]
 ignore_errors = True

-[mypy-manim.mobject.text.code_mobject]
+[mypy-manim.mobject.frame.*]


Suggested change

[mypy-manim.mobject.frame.*]

[mypy-manim.mobject.frame]

chopan050 · 2025-06-22T21:57:49Z

mypy.ini

+[mypy-manim.mobject.graphing.scale.*]
+ignore_errors = False
+
+[mypy-manim.mobject.text.code_mobject.*]
+ignore_errors = False
+
+[mypy-manim.mobject.three_d.three_d_utils.*]
+ignore_errors = False


Suggested change

[mypy-manim.mobject.graphing.scale.*]

ignore_errors = False

[mypy-manim.mobject.text.code_mobject.*]

ignore_errors = False

[mypy-manim.mobject.three_d.three_d_utils.*]

ignore_errors = False

[mypy-manim.mobject.graphing.scale]

ignore_errors = False

[mypy-manim.mobject.text.code_mobject]

ignore_errors = False

[mypy-manim.mobject.three_d.three_d_utils]

ignore_errors = False

henrikmidtiby added 11 commits June 1, 2025 21:46

Fixed mypy errors in several files with a few errors in each file.

e9b8570

Fixed a few easy mypy errors.

9203099

Fix mypy issues in animation/changing.py

e59a677

Handled mypy issues in _config/cli_colors.py

ac64807

Handled mypy issues in mobject/logo.py

29aab6e

Handling mypy errors in fading.py

eadddd9

Removed a default parameter (scene = None) in the method clean_up_fro…

a575573

…m_scene in the class FadeOut

Handled mypy errors in graphing/scale.py

e82131e

Handled a few mypy errors in updaters/update.py

22f2c44

Handled mypy errors in three_d_utils.py

5cf9c00

Updated mypy.ini to check more files

67523e6

github-project-automation bot added this to Dev Board Jun 1, 2025

github-project-automation bot moved this to 🆕 New in Dev Board Jun 1, 2025

github-advanced-security bot found potential problems Jun 1, 2025

View reviewed changes

manim/mobject/three_d/three_d_utils.py Fixed Show fixed Hide fixed

henrikmidtiby and others added 2 commits June 1, 2025 22:28

Avoid a circular import loop.

6318010

[pre-commit.ci] auto fixes from pre-commit.com hooks

d0f423d

for more information, see https://pre-commit.ci

github-advanced-security bot found potential problems Jun 1, 2025

View reviewed changes

manim/mobject/three_d/three_d_utils.py Dismissed Show dismissed Hide dismissed

Merge branch 'main' into FixingFilesWithFewTypingErrors

edf10c6

chopan050 requested changes Jun 22, 2025

View reviewed changes

github-project-automation bot moved this from 🆕 New to 👀 In review in Dev Board Jun 22, 2025

henrikmidtiby and others added 10 commits June 22, 2025 22:24

Update manim/animation/changing.py

d396a80

Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Update manim/animation/changing.py

346ead9

Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Update manim/animation/changing.py

fd6f50d

Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Update manim/mobject/logo.py

c72ca1a

Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Update manim/animation/changing.py

15da91f

Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Update manim/animation/changing.py

2c10cb4

Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Update manim/animation/changing.py

441c873

Cleaner way to indicate the float type Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Update manim/animation/changing.py

b5df67e

Co-authored-by: Francisco Manríquez Novoa <[email protected]>

Updated the type annotations of MoveAlongPath and ChangingDecimal

dc31906

Suggestions from review by chopan50

efb8ab3

Fix missing import.

b552be0

henrikmidtiby requested a review from chopan050 June 22, 2025 20:56

Merge branch 'main' into FixingFilesWithFewTypingErrors

28cb236

chopan050 requested changes Jun 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixing files with few typing (mypy) errors #4263

Fixing files with few typing (mypy) errors #4263

henrikmidtiby commented Jun 1, 2025

Uh oh!

Uh oh!

Uh oh!

chopan050 left a comment

Uh oh!

Uh oh!

Uh oh!

chopan050 Jun 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

henrikmidtiby commented Jun 22, 2025

Uh oh!

chopan050 left a comment

Uh oh!

chopan050 Jun 22, 2025

Uh oh!

chopan050 Jun 22, 2025

Uh oh!

chopan050 Jun 22, 2025

Uh oh!

chopan050 Jun 22, 2025

Uh oh!

Uh oh!

	[mypy-manim._config.cli_colors.*]
	[mypy-manim._config.cli_colors]

Fixing files with few typing (mypy) errors #4263

Are you sure you want to change the base?

Fixing files with few typing (mypy) errors #4263

Conversation

henrikmidtiby commented Jun 1, 2025

Overview: What does this pull request change?

Further Information and Comments

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

chopan050 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chopan050 Jun 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

henrikmidtiby commented Jun 22, 2025

Uh oh!

chopan050 left a comment

Choose a reason for hiding this comment

Uh oh!

chopan050 Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

chopan050 Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

chopan050 Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

chopan050 Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!